Skip to content

feat: report classified controller metrics - #428

Merged
sbalabanov merged 2 commits into
mainfrom
consumer-classified-metrics
Jul 23, 2026
Merged

feat: report classified controller metrics#428
sbalabanov merged 2 commits into
mainfrom
consumer-classified-metrics

Conversation

@sbalabanov

@sbalabanov sbalabanov commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
  • use process.start/process.finish lifecycle metrics for controller counts, latency, and result=success|error|cancel while removing duplicate counters
  • allow Complete() to accept tags accumulated during execution, keeping Begin() tags on both lifecycle metrics and completion tags on finish
  • add origin=infra|infra_retryable|user and dependency=yes|no only after the configured error processor classifies a failure

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbalabanov
sbalabanov marked this pull request as ready for review July 22, 2026 23:17
@sbalabanov
sbalabanov requested review from a team and behinddwalls as code owners July 22, 2026 23:17
@sbalabanov
sbalabanov merged commit 4ddc6a8 into main Jul 23, 2026
26 of 27 checks passed
@behinddwalls
behinddwalls deleted the consumer-classified-metrics branch July 23, 2026 00:17
JamyDev pushed a commit that referenced this pull request Jul 24, 2026
- build on #428 by making the consumer the sole owner of classified
controller and transport lifecycle metrics, removing duplicate
controller, success, and error counters
- migrate gateway and message-queue latency measurements to
`Begin()`/`Complete()`, normalize event counters, and remove nested
consumer scopes
- document framework conventions and cover lifecycle metrics with
focused tests

Co-authored-by: sergeyb <sergeyb@uber.com>
JamyDev pushed a commit that referenced this pull request Jul 24, 2026
- build on #428 by making the consumer the sole owner of classified
controller and transport lifecycle metrics, removing duplicate
controller, success, and error counters
- migrate gateway and message-queue latency measurements to
`Begin()`/`Complete()`, normalize event counters, and remove nested
consumer scopes
- document framework conventions and cover lifecycle metrics with
focused tests

Co-authored-by: sergeyb <sergeyb@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants