feat(buildrunner extension): add shared platform buildkite/githubactions BuildRunner clients - #423
Merged
Merged
Conversation
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 22, 2026 01:42
sbalabanov
requested changes
Jul 22, 2026
…dupe and clean up the buildkite/githubactions HTTP clients.
…wing it, logging a warning at each call site.
…succeeds instead of discarding its error.
…validating it in NewBuildRunner.
… instead of discarding it.
…ite Trigger instead of discarding them.
…f validating it in NewBuildRunner.
…ead of validating it in NewBuildRunner.
…ad of hardcoded not-found strings, matching buildkite.
mnoah1
approved these changes
Jul 27, 2026
roychying
changed the title
sbalabanov
approved these changes
Aug 4, 2026
roychying
enabled auto-merge
August 5, 2026 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platform/extension/buildrunner/and refactor the existing submitqueue adapters to use them.BuildRunneradapters on top of the shared clients.Test plan
go build ./...go test ./platform/extension/buildrunner/... ./submitqueue/extension/buildrunner/... ./stovepipe/extension/buildrunner/...make gazelle(no drift)