Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: links to react-vis on documentation website #1342

Merged
merged 3 commits into from
May 30, 2020
Merged

Hotfix: links to react-vis on documentation website #1342

merged 3 commits into from
May 30, 2020

Conversation

chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented May 30, 2020 •
edited
Loading

This is a hotfix to make sure showcase links continue to work on the website while we continue to work on #1333 .

Since the website build is broken, I did the following steps manually:

  • Create a premodern tag for the repo that's right before we merged the modernization branch
  • Replace all occurrences of blob/master in the bundle with blob/premodern
  • Bust cache

Tested via https://chrisirhc.github.io/react-vis/examples/showcases/plots

@chrisirhc chrisirhc merged commit 4925dad into uber:gh-pages May 30, 2020
@chrisirhc chrisirhc mentioned this pull request May 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiot Xiot Xiot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisirhc @Xiot