Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unischema __getattr__ implementation #656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

v01dXYZ
Copy link

@v01dXYZ v01dXYZ commented Mar 18, 2021

This MR solves #655.

It removes the implementation of the fallback Unischema.__getattr__ which doesn't seem to add any value.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ selitvin
❌ v01dXYZ
You have signed the CLA already but the status is still pending? Let us recheck it.

@selitvin
Copy link
Collaborator

I see that the build is broken for some unrelated reason. Fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants