Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scikit learn to recent versions #694

Closed
wants to merge 5 commits into from

Conversation

SuperBo
Copy link
Contributor

@SuperBo SuperBo commented Oct 17, 2023

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Scikit Learn changes theirs tree implementation through recent versions. This Pull Request is to add changes to adapt with latest SkLearn version.

First, I detect sklearn version then define Cython compile env to detect SKLearn version.

Types of changes

What types of changes does your code introduce to CausalML?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Nothing added.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

@SuperBo SuperBo force-pushed the upgrade-scikit-learn branch from 4a33594 to 3c7c0e6 Compare October 17, 2023 14:24
@jeongyoonlee jeongyoonlee self-requested a review October 20, 2023 01:08
@jeongyoonlee
Copy link
Collaborator

Thanks for your contribution, @SuperBo. Your PR is similar and related to #686, submitted earlier. Once merged, it will remove the scikit-learn dependency and allow users to use whichever scikit-learn version they want.

I look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants