Wrap errors from child workflow in canary sanity workflow #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? Wrap errors when joining Child Workflows and joined all errors to sanity error Why? Previously only the last error from the child workflows was being set to sanity error, and it was not clear if the error was from a child workflow or from sanity workflow. How did you test it? Potential risks Release notes Documentation Changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
canary/sanity.go
Outdated
| @@ -113,7 +117,7 @@ func joinChildWorkflows(ctx workflow.Context, names []string, selector workflow. | |||
| var err1 error | |||
| resultC.Receive(ctx, &err1) | |||
| if err1 != nil { | |||
| err = err1 | |||
| err = errors.Join(err, err1) | |||
There was a problem hiding this comment.
We use multierr.Append in other places. Please check the differences. I'd go with what we have unless we truly need errors.Join here for some reason
taylanisikdemir
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Wrap errors when joining Child Workflows and joined all errors to sanity error
Why?
Previously only the last error from the child workflows was being set to sanity error, and it was not clear if the error was from a child workflow or from sanity workflow.
How did you test it?
Potential risks
Release notes
Documentation Changes
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes