Conversation
psteiger
force-pushed
the
ribevents
branch
2 times, most recently
from
6603976 to
24ed82f
Compare
| /** | ||
| * Sets the extra buffer capacity for [routerEventsFlow] and [ribActionEventsFlow]. | ||
| * | ||
| * This function must be called on the main thread, and before any usage of: |
There was a problem hiding this comment.
What will happen if this isn't true? How can we guarantee it's called before?
There was a problem hiding this comment.
What will happen if this isn't true?
Then, the original value (UNLIMITED) will be used at the moment someone calls one of the RibEvents flow / observable.
How can we guarantee it's called before?
I propose we just do it on our Application.
There was a problem hiding this comment.
What's the earliest we can safely fetch a param? Do we ever call this prior?
There was a problem hiding this comment.
What's the earliest we can safely fetch a param?
It seems we'll just have to bite that first session with some default value, and have the new configuration for the next app starts.
Do we ever call this prior?
No, I don't think there's any access to RibEvents flow before Application.onCreate. AFAIK only ContentProvider can run before, and we don't have any touching RibEvents.
|
Superseded by #653 |
psteiger
changed the title
|
Reopening this PR to land the unit test (although @ignored) |
2 participants
No description provided.