Implement OverridableController to allow for mock overrides #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywhang
reviewed
Jun 29, 2023
Merged
sywhang
added a commit
that referenced
this pull request
Jul 1, 2023
Originally discussed in golang/mock#238. This adds a functional option parameter to NewController to allow adding future configurations to control the behavior of Controller. This will come in handy for implementing features like the one in #22.
sywhang
reviewed
Jul 1, 2023
sywhang
reviewed
Jul 1, 2023
styeung
force-pushed
the
saitoy/overridable-mock
branch
from
5f713a8
to
a473650
Compare
sywhang
approved these changes
Jul 5, 2023
sywhang
added a commit
to sywhang/mock
that referenced
this pull request
Jul 5, 2023
Originally discussed in golang/mock#238. This adds a functional option parameter to NewController to allow adding future configurations to control the behavior of Controller. This will come in handy for implementing features like the one in uber-go#22.
sywhang
pushed a commit
to sywhang/mock
that referenced
this pull request
Jul 5, 2023
This is an initial implementation of the proposal outlined in this issue, golang/mock#685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the proposal outlined in this issue, golang/mock#685