Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed the values of -source & -destination flags to relative … #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abhishekkarunakaran
Copy link

…path

This absolute path values felt redundant.

…path

    This absolute path values felt redundant.
Abhishekkarunakaran

This comment was marked as off-topic.

if err != nil {
log.Fatalf("%v",err)
}
dstPath, err := filepath.Abs(filepath.Dir(strings.Join([]string{currentDir,*destination},string(os.PathSeparator))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this what filepath.Abs() already does if its input isn't an absolute path? Can you give some examples of what you're trying to achieve, please?

Separately, filepath.Join() should be used over strings.Join() in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants