Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mock usability in tests #110

Closed
wants to merge 1 commit into from

Conversation

feldentm-SAP
Copy link

Add stacktrace on fatal exit of mocked call to allow maintainers of tests using this API to understand what is actually going wrong

    Add stacktrace on fatal exit of mocked call to allow maintainers of tests using this API to understand what is actually going wrong
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2023

CLA assistant check
All committers have signed the CLA.

@feldentm-SAP
Copy link
Author

migrate PR from golang/mock#680

@JacobOaks JacobOaks closed this Oct 30, 2023
@feldentm-SAP
Copy link
Author

@JacobOaks I consider this change a bug fix and would be allowed to donate it to the project without signing the CLA. Signing an Uber CLA is currently not that easy.

@JacobOaks JacobOaks reopened this Nov 1, 2023
@JacobOaks JacobOaks closed this Nov 1, 2023
@JacobOaks
Copy link
Contributor

Hi @feldentm-SAP - looks like Github is intent on closing this PR on my behalf for some reason (I did not close this and when I try to re-open it immediately closes it). Let me look into it

@dobrinkamladenova
Copy link

dobrinkamladenova commented Dec 12, 2023

@JacobOaks, to whom may I forward the executed copy of the CLA?

@JacobOaks JacobOaks reopened this Dec 12, 2023
@JacobOaks JacobOaks closed this Dec 12, 2023
@feldentm-SAP
Copy link
Author

I managed to progress on the legal side, but are now facing technical issues with signing the CLA.

@feldentm-SAP
Copy link
Author

@JacobOaks do you know why I'm not allowed to reopen this PR? do you have an idea why I'm presented an empty CLA UI with no means to sign anything?

@feldentm-SAP
Copy link
Author

@JacobOaks I finally managed to sign the CLA and would love this PR to get merged

@feldentm-SAP
Copy link
Author

@JacobOaks thanks for trying, but I created an identical PR in the meantime to work around this issue: #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants