- 
                Notifications
    
You must be signed in to change notification settings  - Fork 316
 
WIP: [PoC] fx.Evaluate #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP: [PoC] fx.Evaluate #1259
Conversation
| 
           This change is part of the following stack: Change managed by git-spice.  | 
    
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
- Coverage   98.62%   97.81%   -0.82%     
==========================================
  Files          35       36       +1     
  Lines        3337     3427      +90     
==========================================
+ Hits         3291     3352      +61     
- Misses         39       63      +24     
- Partials        7       12       +5     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
**This is just a PoC at this time and not yet ready for review.**
## Details
This change introduces the `fx.Evalute` option,
which allows for dynamic generation of provides, invokes, decorates,
and other evaluates based on the state of existing dependencies.
It addresses one of the more significant remaining pain points
with usage of Fx in large applications and ecosystems:
the ability to programmatically generate parts of the dependency graph.
Concretely, this makes the following possible:
```
fx.Evaluate(func(cfg *Config) fx.Option {
    if cfg.Environment == "production" {
        return fx.Provide(func(*sql.DB) Repository {
            return &sqlRepository{db: db}
        }),
    } else {
        return fx.Provide(func() Repository {
            return &memoryRepository{}
        })
    }
}),
fx.Provide(func(...) *sql.DB { ... }),
```
With fx.Evaluate, the dependency on `*sql.DB` is present in the graph
only in production environments.
In development environments, the dependency connection is absent,
and therefore the database connection is never established.
(Today, attempting to write an Fx module that switches on the backend
like this will result in the SQL connection being established even in
development environments.)
**TODO**
- [ ] Decide whether nilling out the slice is the right approach
      for tracking what's been already run
- [ ] fx.Module handling
- [ ] fx.WithLogger handling
- [ ] Testing with every other feature
- [ ] Documentation
    | 
           Great idea.  | 
    
| 
           Looking forward to this 👍  | 
    
| 
           Looking forward to this 👍  | 
    
| 
           Any updates on it?  | 
    
This is just a PoC at this time and not yet ready for review.
Resolves #1132
Details
This change introduces the
fx.Evaluteoption,which allows for dynamic generation of provides, invokes, decorates,
and other evaluates based on the state of existing dependencies.
It addresses one of the more significant remaining pain points
with usage of Fx in large applications and ecosystems:
the ability to programmatically generate parts of the dependency graph.
Concretely, this makes the following possible:
With fx.Evaluate, the dependency on
*sql.DBis present in the graphonly in production environments.
In development environments, the dependency connection is absent,
and therefore the database connection is never established.
(Today, attempting to write an Fx module that switches on the backend
like this will result in the SQL connection being established even in
development environments.)
TODO
for tracking what's been already run