Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns an existing Scope with the same name #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tiscs
Copy link

@Tiscs Tiscs commented Nov 1, 2023

Returns an existing Scope with the same name when calling Scope(name string, opts ...ScopeOption) rather than creating a new one.

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
All committers have signed the CLA.

@JacobOaks
Copy link
Contributor

Hi @Tiscs, in its current state this is a breaking change because it was cause all current calls to Scope() with the same name to be merged into one scope which could break some users.

Instead, we could add a new API to scope that returns a child subscope with a given name, or perhaps an Option that you pass when creating the container that enables this behavior. Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants