Update comments in generated code to align with Go standards #131
+30
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexandear
force-pushed
the
fix-generated-header
branch
from
a41393e
to
c02dd54
Compare
|
I think the How about |
|
This comment won't pass the regular expression (Go syntax) If we really need or with two lines The first line mark Go generated files so all the Go tools recognize it, and the second line is for tools supporting https://generated.at. |
alexandear
changed the title
According to https://golang.org/s/generatedcode the generated Go code should have a comment matches the following regexp: ``` ^// Code generated .* DO NOT EDIT\.$ ```
alexandear
force-pushed
the
fix-generated-header
branch
from
ee429a8
to
10b12e5
Compare
|
You are pretty consistent and patient with this 2 years old PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the comments in generated files to match the standard Go regular expression:
For more information, refer to golang/go#13560 and https://go.dev/s/generatedcode.