Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTPs in dev and production via nginx #262

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

brian-nguyen
Copy link
Collaborator

@brian-nguyen brian-nguyen commented Dec 24, 2018

🎟️ Ticket(s): Closes #


πŸ‘· Changes

  • Add command to generate self-signed certificate and key
  • Add command to start nginx container - mounts config and keys

πŸ”¦ Testing Instructions

Generate keys with make https
Modify the make nginx and nginx.conf according to the comments for development.
Test run the server PORT=9090 go run main.go
Go to http://localhost/start and https://localhost/start to confirm the setup works.

@coveralls
Copy link

coveralls commented Dec 24, 2018

Coverage Status

Coverage remained the same at 66.756% when pulling 3dd68c7 on brian/https into a40948a on master.

server/main.go Show resolved Hide resolved
@teelau teelau self-assigned this Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants