Skip to content

Commit

Permalink
Refactoring and improvements (#366)
Browse files Browse the repository at this point in the history
minor refactoring to variable names and linting
  • Loading branch information
armanmoztar authored Sep 25, 2024
1 parent f8d6c0d commit 32a3f9f
Show file tree
Hide file tree
Showing 11 changed files with 49 additions and 16 deletions.
5 changes: 3 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"root": true,
"extends": [
// "next/core-web-vitals",
"next",
"plugin:@typescript-eslint/recommended",
"prettier"
Expand All @@ -9,6 +9,7 @@
"rules": {
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-unused-vars": "off"
"@typescript-eslint/no-unused-vars": "off",
"no-multi-spaces": ["error"]
}
}
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,4 @@ yarn-error.log*
next-env.d.ts


.vscode
.idea
7 changes: 6 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Ignore artifacts:
build
coverage
node_modules/
.snapshots/
*.min.js
*.spec.js
.vscode/
pnpm-lock.yaml
5 changes: 5 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"editor.tabSize": 2,
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
22 changes: 22 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Contributing to the Launchpad Website

We love your input! We want to make contributing to this project as easy and transparent as possible, whether it's:

- Reporting a bug
- Discussing the current state of the code
- Submitting a fix
- Proposing new features

## Developing workflow

All code changes happen through pull requests.

We use the `main` branch for active changes/additions. The `main` branch is protected, and all changes must be made through pull requests.

1. Create your branch from `main`.
2. Make changes/additions.
3. If you've added code that should be tested, add tests.
4. Ensure all tests pass.
5. Issue a pull request!

At least one reviewer must approve the pull request to enable merging to `main`. Code owners will automatically be added to the pull request.
6 changes: 3 additions & 3 deletions src/app/auth/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,22 @@ export default function Layout({ children }: { children: React.ReactNode }) {
<Image
src={"/images/assets/planet1.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
style={{ objectFit: "contain" }}
/>
</div>
<div className={"w-[267px] h-[200px] absolute left-40 bottom-10"}>
<Image
src={"/images/assets/planet2.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
style={{ objectFit: "contain" }}
/>
</div>
<Image
src={"/images/assets/starsBg.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
style={{ objectFit: "cover" }}
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/globals.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

:root {
--foreground-rgb: 255, 255, 255;
--background-start-rgb: 39, 36, 45;
--background-start-rgb: 39, 33, 45;
--background-end-rgb: 3, 33, 39;
--color-background-primary: 43, 40, 49;
--color-background-secondary: 58, 53, 67;
Expand Down
6 changes: 3 additions & 3 deletions src/components/layouts/genericGreeter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default function GenericGreeter({
<Image
src={"/images/assets/planet1.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
className="hidden xl:block"
style={{ objectFit: "contain" }}
/>
Expand All @@ -27,15 +27,15 @@ export default function GenericGreeter({
<Image
src={"/images/assets/planet2.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
className="hidden xl:block"
style={{ objectFit: "contain" }}
/>
</div>
<Image
src={"/images/assets/starsBg.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
className={"sm:opacity-0 md:opacity-15 xl:opacity-35"}
style={{ objectFit: "cover" }}
/>
Expand Down
6 changes: 3 additions & 3 deletions src/components/layouts/inaccessiblePageWrapper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,22 @@ export default function InaccessiblePageWrapper({
<Image
src={"/images/assets/planet1.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
style={{ objectFit: "contain" }}
/>
</div>
<div className={"w-[267px] h-[200px] absolute left-40 bottom-10"}>
<Image
src={"/images/assets/planet2.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
style={{ objectFit: "contain" }}
/>
</div>
<Image
src={"/images/assets/starsBg.svg"}
alt={"planet"}
layout={"fill"}
fill={true}
style={{ objectFit: "cover" }}
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/data/projects.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
},
{
"title": "Labby ",
"description": "Labby was a ticket management system platform developed in collaboration with the non-profit organization BC Cancer, to meet their needs.",
"description": "Labby was a ticket management system platform developed in collaboration with the non-profit organization BC Cancer, to meet their needs.",
"imageSrc": "https://prod-files-secure.s3.us-west-2.amazonaws.com/bb63397e-5c0d-4017-97b5-2abcd76d406b/7a55ea12-ce50-49f0-bf4b-b0f71c823b23/labby.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45HZZMZUHI%2F20240825%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20240825T232438Z&X-Amz-Expires=3600&X-Amz-Signature=e887fdf4b9e30e0296842f2034456615a2d88439a384048425cbd4a254023a7f&X-Amz-SignedHeaders=host&x-id=GetObject",
"alt": "Mock",
"width": 372,
Expand Down
3 changes: 2 additions & 1 deletion tailwind.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { Config } from "tailwindcss";
import { fontFamily } from "tailwindcss/defaultTheme";
import typography from "@tailwindcss/typography";

const config: Config = {
content: [
Expand Down Expand Up @@ -92,6 +93,6 @@ const config: Config = {
},
},
},
plugins: [require("@tailwindcss/typography")],
plugins: [typography],
};
export default config;

0 comments on commit 32a3f9f

Please sign in to comment.