Changed DB schema to store monetary values as cents and added Dinero to work with money in JS #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns bool indicating whether any rows were deleted
PatrickhySh
approved these changes
Feb 7, 2024
|
LGTM. @daniel-panhead you can merge when you are ready |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately decided to convert DB schema to use cents for storing money as both Dinero.js and the Square API use cents to represent money.
DB types were moved into the db/ folder for more clarity. I also updated the Queryable update() and delete() functions to better signal when the operation had no effect (ex. on a nonexistant object).