Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where multiple non-ajax forms, with validation errors, breaks conditional logic. #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mellodave
Copy link

This happens when there are more than one form on the page, and at least one of them is set to submit without ajax. If this submission results in validation errors, then the original code was setting $_POST['gform_random_id'] for all of the forms on the page, not just for the one that was failing. This resulted in, among other things, conditional logic for all but the last form on the page, to break (because window['gf_form_conditional_logic'] was being overwritten by every form).

This fix tries to detect when a $_POST['gform_random_id'] takes place, and only re-use that id for the form that originally had it. All other forms get new random ids.

The only use case that I could find that is still problematic is when there are more than one form of the same type on the page, and one is set to submit via ajax, and the other is not. This doesn't work - all forms of the same type need to use the same submission methods (ajax, or non-ajax). Forms of different types, however, can be set to have different submission methods, without a problem.

…ticular form on the page, as hidden values in the form submission
…ge when a non-ajax submissions resulted in validation errors, which was then breaking conditional logic
@puremana
Copy link

puremana commented Dec 1, 2020

Thanks for this! Took awhile to realize this was the issue but your solution looks to be working great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants