Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.1: breaks official documentation recommend input -> button DOM element conversion #31

Open
lkraav opened this issue Oct 21, 2018 · 0 comments

Comments

@lkraav
Copy link

lkraav commented Oct 21, 2018

It turns out if following https://docs.gravityforms.com/gform_submit_button/#1-change-input-to-button- this will change single-quotes to double-quotes around id="gform_submit_button_1" and str_replace() fails to match.

Duplicate str_replace() doesn't sound like the right thing to do, but perhaps preg_match()?

Although frankly, duplicate str_replace() for quote variants is easy and simple. Maybe worth it. EDIT especially since I now notice gf_submitting_ string is already forced to do the same thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant