-
Notifications
You must be signed in to change notification settings - Fork 568
quic-style:0.0.1 #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
quic-style:0.0.1 #2380
Conversation
git-subtree-dir: packages/preview/quic-style git-subtree-split: 75b95b8185c453d9c64a96e359771a5d1e863bb9
…preview/quic-style'
…be7aa git-subtree-dir: packages/preview/quic-style/0.0.1 git-subtree-split: 108be7aa47506c885d48a7be86523ed3a98ee675
…preview/quic-style/0.0.1'
…083dbece 083dbece up: package name > `typst-quic-style` -> `quic-style` git-subtree-dir: packages/preview/quic-style/0.0.1 git-subtree-split: 083dbece33e30c5d80517a692f48e185fe8922c2
…a3d1869f a3d1869f fix: typst.toml > template.entrypoint git-subtree-dir: packages/preview/quic-style/0.0.1 git-subtree-split: a3d1869fdf8cd090b3eba18eab8fb437b5951e89
…43edaa2d 43edaa2d up: clean `template` directory git-subtree-dir: packages/preview/quic-style/0.0.1 git-subtree-split: 43edaa2d495aba64d63c430e35c207c0dbaa6de4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this package contains too many files. Only the src
, thumbnails
and template
directories are actually relevant to this repository, the rest won't be accessible easily from Typst Universe and is mostly useful for the package developers. I think you should either remove all these other files, or make them accessible in Typst Universe by referencing them in your README (in the case of docs/manual.pdf
for instance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font files can't be shipped with Typst packages for now. Can you please delete these files and add instructions on how to download and install/import these fonts in Typst to your README or in a comment in your template instead?
…1ab8e git-subtree-dir: packages/preview/quic-style/0.0.1 git-subtree-split: 9f11ab8eda2aa099f7457fdb7a706fffc0931ebd
…preview/quic-style/0.0.1'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing that. Two other small remarks and it should be ready to be merged.
@@ -0,0 +1,125 @@ | |||
#import "@local/quic-style:0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#import "@local/quic-style:0.0.1" | |
#import "@preview/quic-style:0.0.1" |
doi: "", | ||
keywords: (), | ||
abstract: [], | ||
doc_type: "NOTE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, it would be better to use kebab-case here:
doc_type: "NOTE", | |
doc-type: "NOTE", |
And rename it in other places as well.
I am submitting
Description: Explain what the package does and why it's useful.
A cohesive Typst design template that can be used in various situations—daily life, research, and experiments!
Forked from JamesxX/graceful-genetics — thanks!
Since the template received a lot of positive feedback, I thought it might be helpful to others as well, so I took the liberty of making a request.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSEThanks for your review.