Skip to content

quic-style:0.0.1 #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

quic-style:0.0.1 #2380

wants to merge 14 commits into from

Conversation

taniiicom
Copy link

I am submitting

  • a new package
  • an update for a package

Description: Explain what the package does and why it's useful.

A cohesive Typst design template that can be used in various situations—daily life, research, and experiments!
Forked from JamesxX/graceful-genetics — thanks!

Since the template received a lot of positive feedback, I thought it might be helpful to others as well, so I took the liberty of making a request.

Screenshot 2025-05-14 at 17 11 24 Screenshot 2025-05-14 at 17 12 14

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Thanks for your review.

taniiicom added 5 commits May 14, 2025 16:15
git-subtree-dir: packages/preview/quic-style
git-subtree-split: 75b95b8185c453d9c64a96e359771a5d1e863bb9
…be7aa

git-subtree-dir: packages/preview/quic-style/0.0.1
git-subtree-split: 108be7aa47506c885d48a7be86523ed3a98ee675
@typst-package-check typst-package-check bot added the new A new package submission. label May 14, 2025
taniiicom added 6 commits May 14, 2025 17:50
…083dbece

083dbece up: package name > `typst-quic-style` -> `quic-style`

git-subtree-dir: packages/preview/quic-style/0.0.1
git-subtree-split: 083dbece33e30c5d80517a692f48e185fe8922c2
…a3d1869f

a3d1869f fix: typst.toml > template.entrypoint

git-subtree-dir: packages/preview/quic-style/0.0.1
git-subtree-split: a3d1869fdf8cd090b3eba18eab8fb437b5951e89
…43edaa2d

43edaa2d up: clean `template` directory

git-subtree-dir: packages/preview/quic-style/0.0.1
git-subtree-split: 43edaa2d495aba64d63c430e35c207c0dbaa6de4
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this package contains too many files. Only the src, thumbnails and template directories are actually relevant to this repository, the rest won't be accessible easily from Typst Universe and is mostly useful for the package developers. I think you should either remove all these other files, or make them accessible in Typst Universe by referencing them in your README (in the case of docs/manual.pdf for instance).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font files can't be shipped with Typst packages for now. Can you please delete these files and add instructions on how to download and install/import these fonts in Typst to your README or in a comment in your template instead?

taniiicom added 3 commits May 26, 2025 14:32
…1ab8e

git-subtree-dir: packages/preview/quic-style/0.0.1
git-subtree-split: 9f11ab8eda2aa099f7457fdb7a706fffc0931ebd
@taniiicom
Copy link
Author

@elegaanz
Thank you for reviewing.
Sorry for the delayed update.
In commit 859b9fa, I removed unnecessary files for Universe and added instructions to the README on how to install the fonts.

@taniiicom taniiicom requested a review from elegaanz May 26, 2025 05:52
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing that. Two other small remarks and it should be ready to be merged.

@@ -0,0 +1,125 @@
#import "@local/quic-style:0.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#import "@local/quic-style:0.0.1"
#import "@preview/quic-style:0.0.1"

doi: "",
keywords: (),
abstract: [],
doc_type: "NOTE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, it would be better to use kebab-case here:

Suggested change
doc_type: "NOTE",
doc-type: "NOTE",

And rename it in other places as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants