Add most missing delimiters (and more) #69
Conversation
There was a problem hiding this comment.
I strongly dislike the change from .double to stroked. When I talk about ⟦ and ⟧ out loud, I refer to them as "double brackets" or "double square brackets", not "stroked brackets". I understand that this makes sense for shells, but really, even shell.{l,r}.filled sounds bad imo. If we can't find a better solution for now, I suggest we keep .double instead of .stroked, and not introduce shell.{l,r}.filled for now. I am not aware of any use for them, it's not like it's a symbol we need to add immediately.
| .l.t ⌜ | ||
| .l.b ⌞ | ||
| .r.t ⌝ | ||
| .r.b ⌟ |
There was a problem hiding this comment.
| .l.t ⌜ | |
| .l.b ⌞ | |
| .r.t ⌝ | |
| .r.b ⌟ | |
| .tl ⌜ | |
| .bl ⌞ | |
| .tr ⌝ | |
| .br ⌟ |
There was a problem hiding this comment.
I don't think I agree with this change. It's pretty important here that the l modifier means a left delimiter and r means a right delimiter.
There was a problem hiding this comment.
Tho with .l.t there's the issue of writing corner.l or corner.t. This could be resolved with the minimum modifier set idea, but currently the issue would be there.
| angle ∠ | ||
| .l ⟨ | ||
| .l.curly ⧼ | ||
| .l.dot ⦑ | ||
| .l.bar ⦉ |
There was a problem hiding this comment.
If #68 is accepted, this should become a variant of chevron.
| .l.double ⟪ | ||
| .r ⟩ | ||
| .r.curly ⧽ | ||
| .r.dot ⦒ | ||
| .r.bar ⦊ |
There was a problem hiding this comment.
If #68 is accepted, this should become a variant of chevron.
| angle ∠ | ||
| .l ⟨ | ||
| .l.curly ⧼ | ||
| .l.dot ⦑ | ||
| .l.bar ⦉ |
There was a problem hiding this comment.
I don't like the use of .bar here, which is typically for bars that appear over or under a symbol (except for arrows). Maybe .closed would be better?
There was a problem hiding this comment.
Bar is meant to refer to the delimiter here
There was a problem hiding this comment.
I may add that ⧞ is infinity.bar
There was a problem hiding this comment.
I don't this ⧞ is the mos intuitive result for infinity.bar, and i still believe angle.{l,r}.closed would be better (or rather, chevron.{l,r}.closed, taking #68 into account).
There was a problem hiding this comment.
Both ⦇ and ⦅ are closed, but are distinct symbols
There was a problem hiding this comment.
The first one comes from Z notation (⦉ as well btw), which I don't think we have named symbols for as of now.1 I'm wondering whether we should add them. Although I guess I see no immediate reason not to.
Footnotes
-
Only exception I could find for Typst 0.13.1:
circle.filled.tinyfor U+2981 ⦁ Z Notation Spot. ↩
There was a problem hiding this comment.
I see no reason not to add them at some point, but that seems out of scope for a PR focused on delimiters.
Edit: To be clear, the delimiters I mentioned are already part of this PR. I was just trying to explain why we need three different modifiers to describe the "double delimiters"
The thing is that we're using I highly doubt that anyone is going to use these directly without defining some shorthand for them, so I don't see it as a big problem that the name isn't exactly what you would say out loud. |
Adds most of the missing delimiters. These are still missing, mostly because I struggle with naming:
⦌ right square bracket with underbar (U+298C)
⦔ right arc greater-than bracket (U+2994)
⦖ double right arc less-than bracket (U+2996)
The first one would be easier to name once we have a name for the "undermacron".
The proposal document also lists double parentheses, but those do not seem to be math delimiters. I'm not sure what they are exactly, but they're not present in any font I tried.
doublevariants tostrokedfor consistency. This is especially important for the tortoise shells, since there is a filled variant.bar(meant to indicate the delimiter) andstrokedis clear enough.ampto punctuation, as it was in the wrong place.fence.fence.dottedis not a delimiter, and seems entirely unrelated. I didn't do anything with it, however.