Skip to content

Deprecate shin #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate shin #56

wants to merge 1 commit into from

Conversation

mkorje
Copy link
Collaborator

@mkorje mkorje commented Apr 12, 2025

No description provided.

@MDLC01
Copy link
Collaborator

MDLC01 commented Apr 17, 2025

As a side note, there is another Hebrew letter that was used in maths but does not have a corresponding LTR symbol: ת (Tav).1 However, I do not think it is used in modern papers outside of this specific work by Cantor.

Footnotes

  1. https://en.wikipedia.org/wiki/Tav_(number)

@Enivex
Copy link
Collaborator

Enivex commented Apr 26, 2025

As a side note, there is another Hebrew letter that was used in maths but does not have a corresponding LTR symbol: ת (Tav).1 However, I do not think it is used in modern papers outside of this specific work by Cantor.

Footnotes

1. https://en.wikipedia.org/wiki/Tav_(number) [↩](#user-content-fnref-1-49c01f8720ac286de05e560b0e090d2a)

That's not in codex currently no?

@MDLC01
Copy link
Collaborator

MDLC01 commented Apr 26, 2025

Indeed it isn't

@Enivex Enivex self-requested a review May 17, 2025 19:42
Copy link
Collaborator

@Enivex Enivex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to explain the reason for deprecation?

@mkorje
Copy link
Collaborator Author

mkorje commented May 18, 2025

Would something like "shin is deprecated and will be removed as it does not have a corresponding LTR symbol" work? It's maybe a bit too verbose.

@MDLC01
Copy link
Collaborator

MDLC01 commented May 18, 2025

It's maybe a bit too verbose.

And most importantly, most users would have no idea what this means.

@Enivex Enivex self-requested a review May 18, 2025 20:03
@Enivex
Copy link
Collaborator

Enivex commented May 18, 2025

I guess it's fine

@dccsillag
Copy link
Collaborator

dccsillag commented May 18, 2025

It might be worth it to point the users to sha in the deprecation note (since that's what shin would mainly be used for)? (We do have sha in codex, right? I tried to check now but couldn't find it...)

@Enivex
Copy link
Collaborator

Enivex commented May 18, 2025

It might be worth it to point the users to sha in the deprecation note (since that's what shin would mainly be used for)? (We do have sha in codex, right? I tried to check now but couldn't find it...)

No, we do not currently have sha

@MDLC01
Copy link
Collaborator

MDLC01 commented May 19, 2025

Maybe it should be added in this PR then? We can keep other Cyrillic letters for later, but at least if we can provide a sort of replacement it would be great.

@MDLC01
Copy link
Collaborator

MDLC01 commented May 19, 2025

I had not seen #67 when writing the previous comment. Then let's just mention sha in the deprecation message here.

@mkorje
Copy link
Collaborator Author

mkorje commented May 20, 2025

Then let's just mention sha in the deprecation message here.

How does "shin is deprecated, see sha instead" sound? Not sure if saying "use sha instead" is quite right here.

@emilyyyylime
Copy link
Collaborator

"Perhaps you meant to use sha instead"?

@MDLC01
Copy link
Collaborator

MDLC01 commented May 20, 2025

Either are fine I think

@MDLC01 MDLC01 added the breaking This involves a breaking change label May 20, 2025
@MDLC01 MDLC01 requested a review from laurmaedje May 20, 2025 16:41
@dccsillag
Copy link
Collaborator

@emilyyyylime 's suggestion sounds slightly better to me

@mkorje
Copy link
Collaborator Author

mkorje commented May 21, 2025

I've changed it to @emilyyyylime 's suggestion,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This involves a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants