Fix some warnings related to -xsource:3 #890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
approved these changes
Feb 19, 2025
|
|
||
| object MyThing { | ||
| // Impure But What 90% of Folks I know do with log4s | ||
| implicit def unsafeLogger[F[_]: Sync] = Slf4jLogger.getLogger[F] | ||
| implicit def unsafeLogger[F[_] : Sync] = Slf4jLogger.getLogger[F] |
There was a problem hiding this comment.
Is there a warning on these spaces? This is the thing that seems strangest to me.
There was a problem hiding this comment.
The default spaces.beforeContextBoundColon is Never and it doesn't seem configured so it's a bit weird these have been added
bcarter97
reviewed
Feb 20, 2025
| @@ -41,33 +41,33 @@ Good news, you don't have to! Enter log4cats! Read on! | |||
| import org.typelevel.log4cats.Logger | |||
| import org.typelevel.log4cats.slf4j.Slf4jLogger | |||
| import cats.effect.Sync | |||
| import cats.implicits._ | |||
| import cats.implicits.* | |||
There was a problem hiding this comment.
Should these all be changed to cats.syntax.all.*? It's mentioned in these release notes that the latter is preferred
https://github.com/typelevel/cats/releases/tag/v2.2.0
There was a problem hiding this comment.
I'm indifferent to whether it happens in this PR, but 👍 in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #889