Fix async_ usages for new uncancelable semantic
#3063
Conversation
| ) | ||
| } | ||
| ) | ||
| .as(Some(Async[F].delay(sch.close()))) |
There was a problem hiding this comment.
There's potentially some weird life-cycle stuff going on here: AFAIK the only way to cancel an on-going accept is to close the server socket. As the signature is roughly Resource[F, Stream[F, Socket]], where the server socket is tied to the outer resource, in theory you might expect to be able to cancel the inner stream and then start it again.
One way to fix this is to introduce a Channel.synchronous as an intermediary: that way, the stream can be canceled gracefully, without forcing to kill the server socket.
Thoughts?
There was a problem hiding this comment.
There's some related history here: #2300
armanbilge
changed the title
async_ uses for new uncancelable semanticasync_ usages for new uncancelable semantic
|
I can take care of the faraday cage here in a bit. |
|
Actually I can't because I don't have publish rights to |
|
I'm actually doing it right now :) update: |
4 participants
Canaries typelevel/cats-effect#3205.