Run tests against Java 25 #4493
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
commented
Oct 1, 2025
Comment on lines
140
to
+141
| val LatestJava = JavaSpec.temurin("17") | ||
| val LoomJava = JavaSpec.temurin("21") | ||
| val LoomJava = JavaSpec.temurin("25") |
There was a problem hiding this comment.
Can we merge LatestJava and LoomJava?
There was a problem hiding this comment.
I'm not entirely sure what you mean by "merge", but I think we should add 25 without dropping 21 or 17.
- 21 is still in the 8 year LTS period
- Although 17 has exited the 8 year LTS period, Scala 3.8 LTS has chosen to target Java 17 as its minimum version, so IMO it is still a significant version to test against
There was a problem hiding this comment.
If we don't want to further increase the size of the build matrix, in my opinion Java 11 is the least important version.
There was a problem hiding this comment.
Currently we have:
- 8 - EOL 2030 - should remain as long as we support Java 8
- 11 - EOL 2032
- 17 - EOL 2029 - minimum version for upcoming Scala 3.8 LTS
- 21 - EOL 2031 - Loom release
- 25 - EOL 2033 - new LTS/most recent version
Java 11 is a good candidate to drop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.