Skip to content

Add scrollbar to #page-nav #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OddKristensen
Copy link

Took a quick stab at issue 706. There are many ways to solve this, but simply adding a height and a scrollbar on vertical overflow is the easiest solution that does not require additional changes to the DOM. Again, with http4s's changelog as an example it will look like this:

Screenshot 2025-04-25 at 11 54 55

I picked height: 80% because it still looks somewhat ok an really short screens. I found that 90% was too cramped when the screen was getting really short.

With height: 90% it looks like the screenshot on the bottom, where you cannot actually scroll all the way down.

Screenshot 2025-04-25 at 12 01 18

Compared that wight height: 80%:

Screenshot 2025-04-25 at 11 55 33

@jenshalm jenshalm added this to the 1.4.0 milestone Apr 27, 2025
Copy link
Contributor

@jenshalm jenshalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, and thanks for preparing this PR. I wasn't aware of this issue.

Please verify the one suggested change, as the proposed solution breaks pages with short page navigation boxes.

@OddKristensen OddKristensen requested a review from jenshalm April 28, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants