Skip to content

Pass parameters to create function to recreate issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: verify934
Choose a base branch
from
Open

Pass parameters to create function to recreate issue #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ class AdminLogEntity {
public username?: string;
}

interface AdminLogSaveParams {
username?: string,
}

async function main() {
await mongoose.connect(`mongodb://localhost:27017/`, {
dbName: 'verifyMASTER',
Expand All @@ -19,11 +23,26 @@ async function main() {
const adminLogModel: ReturnModelType<typeof AdminLogEntity, BeAnObject> = getModelForClass(AdminLogEntity);
const options: mongoose.CreateOptions = { session };

const adminLogEntity = await adminLogModel.create({}, options);
const params = {
username: 'a',
}

const params2: AdminLogSaveParams = {
username: 'b',
}

// This does not work
const adminLogEntity = await adminLogModel.create(params, options);
// But the next 2 lines work
const adminLogEntity2 = await adminLogModel.create(params2, options);
const adminLogEntity3 = await adminLogModel.create({ username: 'a' }, options);

console.log('entity', adminLogEntity);
console.log('entity2', adminLogEntity2);
console.log('entity3', adminLogEntity3);

await mongoose.disconnect();
}

main();

53 changes: 25 additions & 28 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,27 @@
{
"compileOnSave": true,
"typeAcquisition": {
"enable": true
},
"compilerOptions": {
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"declarationMap": true,
"outDir": "lib",
"moduleResolution": "node",
"target": "ES2021",
"module": "commonjs",
"newLine": "LF",
"sourceMap": true,
"removeComments": true,
"strict": true,
"allowUnreachableCode": false,
"pretty": true,
"declaration": true,
"incremental": true,
"tsBuildInfoFile": ".tsbuildinfo",
"lib": [
"esnext"
]
},
"include": [
"src/**/*"
]
"compileOnSave": true,
"typeAcquisition": {
"enable": true
},
"compilerOptions": {
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"declarationMap": true,
"outDir": "lib",
"moduleResolution": "node",
"target": "ES2021",
"module": "commonjs",
"newLine": "LF",
"sourceMap": true,
"removeComments": true,
"strict": true,
"strictPropertyInitialization": false,
"allowUnreachableCode": false,
"pretty": true,
"declaration": true,
"incremental": true,
"tsBuildInfoFile": ".tsbuildinfo",
"lib": ["esnext"]
},
"include": ["src/**/*"]
}