fix(getport): Randomize first port using crypto#844
Merged
hasezoey merged 2 commits intotypegoose:masterfrom Jan 13, 2024
Merged
fix(getport): Randomize first port using crypto#844hasezoey merged 2 commits intotypegoose:masterfrom
hasezoey merged 2 commits intotypegoose:masterfrom
Conversation
The current implementation of `getPort()` relies on using `Date.now()` to get the first port to try to launch mongo on, even when the `EXP_NET0LISTEN` flag is set. This causes a couple issues: - If the `Date` module is mocked, it can result in `getFreePort()` returning the same first port every time. - If multiple mongos are being started at once in parallel, it's possible for the same first port to be picked leading to port conflicts In order to better randomize the initial port selection so that port conflicts can be avoided, instead of using `Date.now()` for an initial seed, use `crypto.randomInt()` which should provide more randomness and hopefully avoid some of these race conditions. Fixes typegoose#827
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
==========================================
+ Coverage 91.22% 91.24% +0.01%
==========================================
Files 15 15
Lines 1984 1988 +4
Branches 499 501 +2
==========================================
+ Hits 1810 1814 +4
Misses 165 165
Partials 9 9 ☔ View full report in Codecov by Sentry. |
hasezoey
approved these changes
Jan 13, 2024
Member
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
Thanks, didnt know about the crypto function (though i knew about Math.random, but for some reason i cant remember didnt use it)
|
🎉 This PR is included in version 9.1.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
getPort()relies on usingDate.now()to get the first port to try to launch mongo on, even when theEXP_NET0LISTENflag is set. This causes a couple issues:Datemodule is mocked, it can result ingetFreePort()returning the same first port every time.In order to better randomize the initial port selection so that port conflicts can be avoided, instead of using
Date.now()for an initial seed, usecrypto.randomInt()which should provide more randomness and hopefully avoid some of these race conditions.Related Issues