Add stub for django.db.models.expressions.Expression.identity
#2685
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjwatson
force-pushed
the
expression-identity
branch
3 times, most recently
from
32bd96a to
5f742de
Compare
|
Sorry I'm taking so many tries at this - I haven't managed to get the stub tests working locally so the iteration time is kind of long! Hopefully this time should be closer. |
cjwatson
force-pushed
the
expression-identity
branch
from
5f742de to
967786c
Compare
|
I eventually found python/mypy#18959 that explains the errors I was running into. I've added |
|
We don't need this anymore, since mypy1.16 solved this problem :) |
I don't think we need to be very specific about the contents of the returned tuple; it's just used for comparison and hashing methods.
cjwatson
force-pushed
the
expression-identity
branch
from
967786c to
aef7fb9
Compare
|
Indeed! Rebased to get rid of that. |
jose-reveni
pushed a commit
to jose-reveni/django-stubs
that referenced
this pull request
Jun 9, 2025
…ddjango#2685) I don't think we need to be very specific about the contents of the returned tuple; it's just used for comparison and hashing methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need to be very specific about the contents of the returned tuple; it's just used for comparison and hashing methods.