Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Only read TLS CA once #281

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

dmitrii-ubskii
Copy link
Member

What is the goal of this PR?

We modify the cluster server client so that it only reads the TLS root CA once (if provided), and reuses the SSL credentials when prompted for a new channel.

What are the changes implemented in this PR?

Drive-by: don't crash trying to access auth token before the stub is created.

Closes #280.
Closes #273.

@typedb-bot
Copy link
Member

typedb-bot commented Jan 25, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@flyingsilverfin flyingsilverfin merged commit d701eaf into typedb:master Jan 25, 2023
@dmitrii-ubskii dmitrii-ubskii deleted the cluster-tls-280 branch March 3, 2023 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster server client - TLS certificate is read once per-transaction. Cluster server client: stub creation depends on stub
4 participants