Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Depend on grpcio<2, protobuf<4 #275

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

alexjpwalker
Copy link
Member

@alexjpwalker alexjpwalker commented Jan 5, 2023

What is the goal of this PR?

We increased the flexibility of our dependency requirements. Any version of grpcio < 2 and protobuf < 4 are now acceptable.

What are the changes implemented in this PR?

We have previously had to do a new release of this client whenever someone depends on a different version of grpcio or protobuf in their project - in particular, even if they are depending on a newer version. This is not a good experience for developers.

Now, we accept any version that is expected to be non-breaking.

@typedb-bot
Copy link
Member

typedb-bot commented Jan 5, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@alexjpwalker alexjpwalker self-assigned this Jan 5, 2023
@alexjpwalker alexjpwalker added this to the Technical Debt milestone Jan 5, 2023
@alexjpwalker alexjpwalker marked this pull request as ready for review January 5, 2023 18:17
@alexjpwalker alexjpwalker merged commit 8b4fe67 into typedb:master Jan 5, 2023
@alexjpwalker alexjpwalker linked an issue Jan 5, 2023 that may be closed by this pull request
@alexjpwalker alexjpwalker deleted the loose-dep-versions branch January 5, 2023 18:18
@alexjpwalker alexjpwalker linked an issue Jan 11, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not install typedb-client: legacy-install-failure Support Python 3.11 By Bumping grpcio tools
3 participants