This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Depend on grpcio<2, protobuf<4 #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We increased the flexibility of our dependency requirements. Any version of
grpcio < 2
andprotobuf < 4
are now acceptable.What are the changes implemented in this PR?
We have previously had to do a new release of this client whenever someone depends on a different version of
grpcio
orprotobuf
in their project - in particular, even if they are depending on a newer version. This is not a good experience for developers.Now, we accept any version that is expected to be non-breaking.