Add test vectors for Praos (ver03) #3
Conversation
|
I think only adding test vectors without test runner is a bit odd. |
leave only ver03 vectors and make them jsons
paweljakubas
force-pushed
the
paweljakubas/2/add-test-vectors
branch
from
61308ca to
e08a12d
Compare
paweljakubas
requested review from
abailly and
scarmuega
and removed request for
AndrewWestberg
src/vrf03.rs
Outdated
| let output_expected = | ||
| hex::decode(test_vector.get("beta").unwrap().as_str().unwrap()).unwrap(); | ||
|
|
||
| assert_eq!(vrf_name, "PraosVRF"); |
There was a problem hiding this comment.
these assertions seem rather pointless
There was a problem hiding this comment.
indeed, removed!
src/vrf03.rs
Outdated
| let test_vector: serde_json::Value = | ||
| serde_json::from_reader(file).expect("JSON was not well-formatted"); | ||
|
|
||
| let vrf_name = test_vector.get("vrf").unwrap().as_str().unwrap(); |
There was a problem hiding this comment.
We should create a VRFTestVector structure and have serve take care of deserialisation, along with proper types for each member. Using automatic derivation should remove quite a lot of boilerplate conversion I think
There was a problem hiding this comment.
here is some code I wrote to handle deserialisation from hex encoded string into bytes: https://github.com/pragma-org/amaru/blob/81a72af8a5b145ecfcee9a255d129fb703efdccf/crates/ouroboros/tests/validation.rs#L109
There was a problem hiding this comment.
thank you very much for this remark and request. Used serde and its deserialization as requested!
src/vrf03.rs
Outdated
|
|
||
| #[test] | ||
| fn check_against_cardano_base() { | ||
| check_against_golden("./tests/test_vectors/vrf_ver03_generated_1"); |
There was a problem hiding this comment.
create a static const test_vectors : [&'static str; 8] = [ .... ] and then iterate over the vector, eg. a parametric test
There was a problem hiding this comment.
Here is a proposed patch to simplify the deserialisation of test vectors. Also, I wonder what's the relationship between those JSON formatted test vectors and the ones which are inline part of the code?
Last suggestion: instead of adding one file for each test vector, just add one vrf03_golden_tests.json file containing a list.
The PR adds test vectors as checked/generated in cardano-base for VRF:
The mirror PR generating/checking the added test vectors is here : IntersectMBO/cardano-base#519