Conversation
|
Happy to remove the Also not sure yet about the test data this uses. Right now it's just the first 4 messages created by the Haskell implementation (on one run, it's probabilistic) |
b82f9bf to
9915040
Compare
|
@scarmuega Any opinion on this general approach? |
cfdbaba to
6d370c6
Compare
|
Moved the nix bits into an own repository I can easily pull into my workflow for pallas (https://github.com/ch1bo/rust-flake) I will look into this cargo |
|
@scarmuega: @KtorZ and me discussed this briefly and we thought putting the |
This is using example test data extracted from the Haskell implementations test of handshake n2n for v13+
This makes new users not worry about the cardano-blueprint submodule when they first checkout and `cargo test` the whole project.
f6b4f1d to
a65c81d
Compare
|
@scarmuega This should be ready now. The CI action seems not to run on I also updated the PR description to explain how the feature flag works. |
|
Was merged by closing #638 |
This demonstrates how we could test against test vectors in a common repository from multiple implementations of the ouroboros protocols.
For that matter, simple serialization roundtrip tests against the handshake protocol cddl are added in this PR.
The
cardano-blueprintis added as a submodule, but tests using data from it are gated by ablueprintfeature flag.This means, new contributors would experience this workflow:
git clone git@github.com:txpipe/pallas.git && cd pallascargo test-> works, while tests usingcardano-blueprintare not runblueprinttests!cargo test --features blueprint-> fails because submodule not checked outgit submodule update --initchecks out submodulecargo test --features blueprint-> works now