Linting fixes - Release Prep v2.1.0

twostack · Nov 12, 2024 · b4843a8 · b4843a8
1 parent 068dc74
commit b4843a8
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 26 deletions.
diff --git a/lib/src/block/merkleblock.dart b/lib/src/block/merkleblock.dart
@@ -34,8 +34,8 @@ class MerkleBlock {
     int? _numTransactions;
     List? _hashes;
     List? _flags;
-    int _flagBitsUsed = 0;
-    int _hashesUsed = 0;
+    // int _flagBitsUsed = 0;
+    // int _hashesUsed = 0;
 
 
 

diff --git a/lib/src/crypto/childnumber.dart b/lib/src/crypto/childnumber.dart
@@ -59,7 +59,7 @@ class ChildNumber implements Comparable<ChildNumber> {
 
     bool operator ==(otherChild){
 
-        if (otherChild == null || runtimeType != otherChild.runtimeType)
+        if (runtimeType != otherChild.runtimeType)
             return false;
 
         return this._i == (otherChild as ChildNumber).i;

diff --git a/lib/src/crypto/ecies.dart b/lib/src/crypto/ecies.dart
@@ -14,7 +14,7 @@ import 'package:pointycastle/pointycastle.dart';
 /// This class only makes provision for the "Electrum ECIES" aka "BIE1" serialization
 /// format for the cipherText.
 class Ecies {
-  final ECDomainParameters _domainParams =  ECDomainParameters('secp256k1');
+  // final ECDomainParameters _domainParams =  ECDomainParameters('secp256k1');
   final SHA256Digest _sha256Digest = SHA256Digest();
   final tagLength = 32; //size of hmac
 
@@ -109,7 +109,7 @@ class Ecies {
 
     //calculate S = recipientPrivateKey o senderPublicKey
     final S = (senderPublicKey.point * recipientPrivateKey.privateKey)!; //point multiplication
-    final cipher = S.x;
+    // final cipher = S.x;
 
     if (cipherText.length - tagLength <= 37 ){
       throw Exception('Invalid Checksum detected. Combined sum of Checksum and Message makes no sense');

diff --git a/lib/src/encoding/ckdserializer.dart b/lib/src/encoding/ckdserializer.dart
@@ -49,10 +49,10 @@ abstract class CKDSerializer {
 
         var versionBytes =   getVersionBytes();
 
-        var depth = this._nodeDepth;
-        var fingerprint = this._parentFingerprint;
-        var chainCode = this._chainCode;
-        var pubkeyHex = this._keyHex;
+        // var depth = this._nodeDepth;
+        // var fingerprint = this._parentFingerprint;
+        // var chainCode = this._chainCode;
+        // var pubkeyHex = this._keyHex;
 
         List<int> serializedKey = List<int>.filled(78, 0);
         serializedKey.setRange(0, 4, versionBytes);

diff --git a/lib/src/script/svscript.dart b/lib/src/script/svscript.dart
@@ -1,4 +1,3 @@
-import 'dart:convert';
 import 'dart:typed_data';
 import 'package:collection/collection.dart';
 import 'package:dartsv/src/encoding/utils.dart';

diff --git a/lib/src/transaction/default_builder.dart b/lib/src/transaction/default_builder.dart
@@ -1,11 +1,8 @@
 
-import 'dart:typed_data';
+import 'package:dartsv/src/script/svscript.dart';
 
-import 'package:dartsv/src/transaction/signed_unlock_builder.dart';
-import 'package:hex/hex.dart';
-import 'package:sprintf/sprintf.dart';
-
-import '../../dartsv.dart';
+import 'locking_script_builder.dart';
+import 'unlocking_script_builder.dart';
 
 
 class DefaultLockBuilder extends LockingScriptBuilder {

diff --git a/lib/src/transaction/p2sh_builder.dart b/lib/src/transaction/p2sh_builder.dart
@@ -1,13 +1,17 @@
 
 import 'dart:typed_data';
 
+import 'package:dartsv/src/encoding/utils.dart';
 import 'package:dartsv/src/exceptions.dart';
 import 'package:dartsv/src/script/opcodes.dart';
-import 'package:dartsv/src/transaction/signed_unlock_builder.dart';
+import 'package:dartsv/src/script/script_error.dart';
+import 'package:dartsv/src/script/svscript.dart';
+import 'package:dartsv/src/transaction/script_builder.dart';
 import 'package:hex/hex.dart';
-import 'package:sprintf/sprintf.dart';
 
-import '../../dartsv.dart';
+import 'locking_script_builder.dart';
+import 'unlocking_script_builder.dart';
+
 
 
 class P2SHLockBuilder extends LockingScriptBuilder {

diff --git a/lib/src/transaction/signed_unlock_builder.dart b/lib/src/transaction/signed_unlock_builder.dart
@@ -1,5 +1,6 @@
 
-import '../../dartsv.dart';
+
+import 'package:dartsv/src/signature.dart';
 
 /// All unlocking scripts that will use OP_CHECKSIG or OP_CHECKMULTISIG operations
 /// must implement this interface. Implementing this interface will signal to

diff --git a/lib/src/transaction/transaction_output.dart b/lib/src/transaction/transaction_output.dart
@@ -1,14 +1,10 @@
-import 'dart:typed_data';
 
 import 'package:buffer/buffer.dart';
-import 'package:dartsv/src/address.dart';
 import 'package:dartsv/src/encoding/utils.dart';
+import 'package:dartsv/src/script/opcodes.dart';
 import 'package:dartsv/src/script/svscript.dart';
-import 'package:hex/hex.dart';
-import '../../dartsv.dart';
-import 'default_builder.dart';
+import 'package:dartsv/src/varint.dart';
 import 'transaction.dart';
-import 'package:sprintf/sprintf.dart';
 
 /// Class that represents the output (UTXO) of a transaction.
 ///