Remove time unit and column from python and make time the first column #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that derived time series will have time as the first column, regardless of its position in the source series. Issue twosigma#8 is fixed by using the corrected Scala schema after a call to groupByCycle, as the result has time as first column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #8 and issue #9.
The time_column and unit arguments have been removed from the TimeSeriesDataFrame python constructor.
If the time column is not the first column it is moved to be the first column of the result. This behavior was already enforced in Scala and is now properly handled in Python including the code that caused issue #8.