-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review of ts jgss jdk12 #1
base: jdk12-master
Are you sure you want to change the base?
Commits on Sep 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0b47709 - Browse repository at this point
Copy the full SHA 0b47709View commit details
Commits on Oct 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e7b31c2 - Browse repository at this point
Copy the full SHA e7b31c2View commit details -
Fix error handling in GSSLibStub
Also improve object size handling in NativeUtil.
Configuration menu - View commit details
-
Copy full SHA for 003d82b - Browse repository at this point
Copy the full SHA 003d82bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0191c79 - Browse repository at this point
Copy the full SHA 0191c79View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d26b3 - Browse repository at this point
Copy the full SHA f8d26b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a9e744 - Browse repository at this point
Copy the full SHA 2a9e744View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2ad2c5 - Browse repository at this point
Copy the full SHA e2ad2c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63dcbe5 - Browse repository at this point
Copy the full SHA 63dcbe5View commit details -
Add createCredential() with password
Also avoid memory allocation in newGSSOIDSet() renamed to makeGSSOIDset() which now takes a singleton set argument and either assigns the requested OID or with SPNEGO returns a static list of all the supported mechs. With this we no longer need deleteGSSOIDSet().
Configuration menu - View commit details
-
Copy full SHA for a742c8e - Browse repository at this point
Copy the full SHA a742c8eView commit details -
JGSS: Don't dispose() of creds too eagerly
We must not dispose() of any credential handle passed to the NativeGSSContext() constructor. But we must dispose() of credentials that are acquired in NativeGSSContext. This is very important because the JVM does not know about the size of the JNI credential objects, so it doesn't readily recognize memory pressure from them, leading to memory pressure issues in SASL and GSS server applications.
Configuration menu - View commit details
-
Copy full SHA for d975a3d - Browse repository at this point
Copy the full SHA d975a3dView commit details -
Fix SpNego multi-round-trip bug
There is only one token that we can extract an actual mechanism OID from in the SPNEGO case when the native GSS library doesn't provide that (though it should) in the API. If the SPNEGO exchange ends up requiring more than two tokens, then the previous code failed to establish a security context. Also, never raise if we cannot get an actual mech OID from SPNEGO tokens.
Configuration menu - View commit details
-
Copy full SHA for 561e7f4 - Browse repository at this point
Copy the full SHA 561e7f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5840bfd - Browse repository at this point
Copy the full SHA 5840bfdView commit details -
ServicePermission empty realm support
Also use empty realm as wildcard for krbtgt names
Configuration menu - View commit details
-
Copy full SHA for ac1f706 - Browse repository at this point
Copy the full SHA ac1f706View commit details -
Configuration menu - View commit details
-
Copy full SHA for 837a750 - Browse repository at this point
Copy the full SHA 837a750View commit details -
Configuration menu - View commit details
-
Copy full SHA for 173c04b - Browse repository at this point
Copy the full SHA 173c04bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7cd095 - Browse repository at this point
Copy the full SHA b7cd095View commit details -
This module is to be used for GSS applications in preference to Krb5LoginModule, especially when using the native GSS provider.
Configuration menu - View commit details
-
Copy full SHA for 89341f8 - Browse repository at this point
Copy the full SHA 89341f8View commit details -
Engage GssLoginModule (only) when native=true
Also don't force same name for acceptor and initiator.
Configuration menu - View commit details
-
Copy full SHA for 98f952f - Browse repository at this point
Copy the full SHA 98f952fView commit details -
Add commentary about native in Krb5LoginModule
Configuration menu - View commit details
-
Copy full SHA for 78a7cac - Browse repository at this point
Copy the full SHA 78a7cacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a494b0 - Browse repository at this point
Copy the full SHA 5a494b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac27524 - Browse repository at this point
Copy the full SHA ac27524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90d3097 - Browse repository at this point
Copy the full SHA 90d3097View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a541ee - Browse repository at this point
Copy the full SHA 5a541eeView commit details -
JGSS: Simplify context permissions checks
We were reacquiring the initiator/acceptor credential upon security context full establishment in order to indirectly perform a permission check on the srcName/targName once we find out what they are. But this is just one more way to end up failing, which happens with Heimdal when using SPNEGO because we ask to acquire a Kerberos credentials using a SPNEGO MN and that fails. Also, there was a security bug here: if the permission check fails then we raise, but if the application already has a context handle, then it can use it anyways if it catches the exception! The fix for this is to dispose() when the permission check fails.
Configuration menu - View commit details
-
Copy full SHA for 192cc47 - Browse repository at this point
Copy the full SHA 192cc47View commit details -
Dispose of delegated cred handles early
Native objects are memory icebergs: they are much larger than the JVM knows, so the GC might not dispose of them soon enough.
Configuration menu - View commit details
-
Copy full SHA for 16f33b3 - Browse repository at this point
Copy the full SHA 16f33b3View commit details