Open
Conversation
fastrde
commented
Apr 26, 2020
| if not self.connected: | ||
| raise LDAPServerConnectionLostException() | ||
| msg = pureldap.LDAPMessage(op, id=id) | ||
| msg = pureldap.LDAPMessage(op, controls=controls, id=id) |
Author
There was a problem hiding this comment.
controls=None is handled in pureldap so no need to handle it here. so just pass it.
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 93.35% 90.64% -2.71%
==========================================
Files 72 72
Lines 9914 9898 -16
Branches 972 974 +2
==========================================
- Hits 9255 8972 -283
- Misses 537 802 +265
- Partials 122 124 +2
Continue to review full report at Codecov.
|
|
This also solved my issue where I was seeing this exception on my client app: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #163 for details.
Don't merge without further investigation!
It's the example how i solved this for my usecase.