Repository navigation
fix: update resource set page limit when changing record limit - #993
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
ResourceSet.setLimitsilently truncating iteration at the old page boundary when the limit is raised. No existing issue is associated with this fix.ResourceSetcomputespageLimitonce in its constructor, andsetLimitonly updates the reader, sofetchNextPagekeeps stopping at the old page count. For example, a set created with page size 2 and limit 2 still returns only two records aftersetLimit(4), even when another page is available.Recalculate the page limit in
setLimit, using the first page's size as the constructor does. Add a regression test with two pages that checks all four records are returned and the next page is fetched.Testing and validation
mvn -q -Dtest=ResourceSetIterationTest testinmaven:3-eclipse-temurin-17: before the fix, 3 tests ran with 1 regression failure (two records instead of four); after the fix, all 3 tests passed.ResourceSetResponseTestandReaderTestalso pass.Checklist
AI assistance was used to prepare this change and its regression test.