Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing org.json as this repo doesnot contain a direct dependency #743

Merged
merged 2 commits into from
May 5, 2023
Merged

fix: Removing org.json as this repo doesnot contain a direct dependency #743

merged 2 commits into from
May 5, 2023

Conversation

AsabuHere
Copy link
Contributor

Fixes

A short description of what this PR does.
moving org.json to test scope

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@AsabuHere AsabuHere requested a review from kridai May 5, 2023 07:22
@AsabuHere AsabuHere requested a review from charan678 May 5, 2023 07:38
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AsabuHere AsabuHere merged commit c8169fd into main May 5, 2023
@AsabuHere AsabuHere deleted the update_orgjson_scope branch May 5, 2023 07:55
@AsabuHere AsabuHere changed the title fix: moving org.json to test scope fix: Removing org.json as this repo doesnot contain a direct dependency May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kridai kridai kridai approved these changes

@charan678 charan678 Awaiting requested review from charan678

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AsabuHere @kridai