-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(keyboard-key): add documentation #4164
base: main
Are you sure you want to change the base?
Conversation
…to docs/keyboard-key-init
… into docs/keyboard-key-init
All else looks great!!! |
Good catch, fixed in latest commit
I originally kept these under examples but the spec doc is structured differently so I will make these changes
It would depend on whether the blockquote will be merged before this docs. We do have other blockqoutes throughout the site so we should do a cleanup as part of the docs ticket for Blockquote.
I double checked and I'm not adding any extra margins left, only bottom for the List component |
Very good point @jhanvi1399! I looked through and saw that list was using the markdown syntac but I'm using the list component which renders it in a different way. Pushed up a fix in latest commit. |
Paste Run #9100
Run Properties:
|
Project |
Paste
|
Branch Review |
docs/keyboard-key-init
|
Run status |
Passed #9100
|
Run duration | 06m 09s |
Commit |
e9e663ae0b ℹ️: Merge 4bed0a903dbc680928aca55e292ab8e9981331b4 into 7f39856ee3697235b535ea02eaef...
|
Committer | krisantrobus |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
125
|
View all changes introduced in this branch ↗︎ |
Added documentation from the spec.
https://paste-docs-git-docs-keyboard-key-init-twilio.vercel.app/components/keyboard-key