Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with Node 18 Warning #501

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Conversation

dooley1001
Copy link
Contributor

Description

Added a warning message to README about Node18 release as this may effect code snippets present in this repository.

Checklist

  • I ran npm test locally and it passed without errors.
  • I acknowledge that all my contributions will be made under the project's license.

Related issues

#478

Added warning message to README about Node18 release.
@dooley1001 dooley1001 mentioned this pull request Jan 24, 2024
2 tasks
@makserik
Copy link
Contributor

Hey @dooley1001 thank you for the PR. I have gotten extra context in the meanwhile and it seems the warning might be redundant at the moment. As Functions & Assets uses Twilio runtime-handler to bootstrap all of the functions this means that until we migrate the runtime-handler to use ESM, there are no errors expected.

I would still leave the link you have proposed and specify that importing ESM-only modules might cause errors.

@dooley1001
Copy link
Contributor Author

What shall i remove @makserik ?

Removed the warning comment from README.md
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -4,9 +4,11 @@

[Twilio Functions](https://www.twilio.com/functions) are a serverless environment to build and run Twilio applications so you can get to production faster. You provide the Node.js code to perform the task you need and Twilio runs it. You can read [more about Twilio Functions and how to use them in the introductory blog post](https://www.twilio.com/blog/2017/05/introducing-twilio-functions.html).

## This repo
### This Repo is now out of date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason to add this, there seems to be no plans to deprecate CJS. nodejs/node#33954

Removed warning about repo being out of date
Removed Warning and replaced with "Attention"
@makserik makserik self-assigned this Mar 15, 2024
@makserik makserik merged commit ce1653b into twilio-labs:main Mar 15, 2024
2 of 3 checks passed
Copy link

welcome bot commented Mar 15, 2024

Congratulations on your first contribution to the Twilio Function Templates!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
To stay up-to-date with Twilio open source related updates, sign up here: https://twil.io/oss-updates
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants