-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with Node 18 Warning #501
Conversation
Added warning message to README about Node18 release.
Hey @dooley1001 thank you for the PR. I have gotten extra context in the meanwhile and it seems the warning might be redundant at the moment. As Functions & Assets uses Twilio runtime-handler to bootstrap all of the functions this means that until we migrate the runtime-handler to use ESM, there are no errors expected. I would still leave the link you have proposed and specify that importing ESM-only modules might cause errors. |
What shall i remove @makserik ? |
Removed the warning comment from README.md
README.md
Outdated
@@ -4,9 +4,11 @@ | |||
|
|||
[Twilio Functions](https://www.twilio.com/functions) are a serverless environment to build and run Twilio applications so you can get to production faster. You provide the Node.js code to perform the task you need and Twilio runs it. You can read [more about Twilio Functions and how to use them in the introductory blog post](https://www.twilio.com/blog/2017/05/introducing-twilio-functions.html). | |||
|
|||
## This repo | |||
### This Repo is now out of date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason to add this, there seems to be no plans to deprecate CJS. nodejs/node#33954
Removed warning about repo being out of date
Removed Warning and replaced with "Attention"
Congratulations on your first contribution to the Twilio Function Templates! |
Description
Added a warning message to README about Node18 release as this may effect code snippets present in this repository.
Checklist
npm test
locally and it passed without errors.Related issues
#478