Fix the issue of Twilio sometimes starting a new websocket connection for the same call concurrently #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the same call concurrently
kevinmershon
commented
Oct 3, 2024
|
|
||
| let interactionCount = 0; | ||
|
|
||
| transcriptionService.on('utterance', async (text) => { |
There was a problem hiding this comment.
all of this code is just moved from below into this bindCall wrapper.
| ttsService.generate({partialResponseIndex: null, partialResponse: 'Hello! I understand you\'re looking for a pair of AirPods, is that correct?'}, 0); | ||
|
|
||
| getCallerNumber(msg.start).then((number) => { | ||
| if (activeCalls[number]) { |
There was a problem hiding this comment.
refuse to initiate multiple streams for the same inbound/from caller number
kevinmershon
force-pushed
the
bugfix-twilio-stream-restart-fix
branch
from
5763141
to
9b79929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in testing that Twilio sometimes re-invokes a websocket connection during the call which was resulting in duplicated streams running and me hearing multiple confused TTS voices at different stages of my call flow. By refusing to initiate more than one call per unique calling phone number, this problem was completely eliminated for me.
If it helps, I was calling from a cellphone with wifi-based calling enabled so I considered it's possible that when a cellphone switches from wifi-calling back to the 4G network that Twilio thinks the stream was interrupted and tries to open a new webosocket.
Contributing to Twilio