Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes before 0-35 release #9176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes before 0-35 release #9176

wants to merge 1 commit into from

Conversation

charlesBochet
Copy link
Member

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Refactored tab management in show pages by moving URL synchronization responsibility from TabList to a dedicated ShowPageTabListFromUrlOptionalEffect component.

  • Introduced ShowPageTabListFromUrlOptionalEffect in /packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageTabListFromUrlOptionalEffect.tsx to handle URL-based tab state
  • Added isInRightDrawer prop to disable URL sync when tabs are shown in drawer context
  • Removed URL synchronization from TabList.tsx to make it a more generic, presentation-focused component
  • Created unique tabListComponentId in ShowPageSubContainer to prevent state conflicts between instances

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants