Fix horizontal line visibility on login page when no SSO providers are available #9139
+2
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes redundant horizontal separators from the login page UI by eliminating explicit separator components in SignInUpWorkspaceScopeForm.tsx.
- Removed unnecessary HorizontalSeparator from
/packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpWorkspaceScopeForm.tsxsince each auth provider (Google, Microsoft, SSO) already includes its own - Fixed visual issue where horizontal lines would appear even when no SSO providers were available
- Improves UI consistency by only showing separators when auth providers are actually present
💡 (5/5) You can turn off certain types of comments like style here!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -32,14 +32,7 @@ export const SignInUpWorkspaceScopeForm = () => { | |||
| {workspaceAuthProviders.microsoft && <SignInUpWithMicrosoft />} | |||
|
|
|||
| {workspaceAuthProviders.sso.length > 0 && <SignInUpWithSSO />} | |||
There was a problem hiding this comment.
style: inconsistent spacing - extra blank line after SSO but not after other providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #9094
All components ,, have their own Horizontal Separator so we don't require extra Horizontal Separator.
Please review @BOHEUS . Let me know if further adjustments are needed.