Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue of scroll paddings in Navigation Drawer #9138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muraliSingh7
Copy link
Contributor

This PR fixes the issue #9026

Screenshot:
image
image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes scroll padding issues in the Navigation Drawer by ensuring proper scrollbar visibility and preventing overlap with navigation items.

  • Removed scrollHide={true} from ScrollWrapper in packages/twenty-front/src/modules/navigation/components/MainNavigationDrawerItems.tsx to show scrollbar
  • Added theme-based spacing and width calculations in packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx for better layout
  • Implemented margin-right in packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerSectionTitle.tsx to prevent scrollbar overlap
  • Improved text overflow handling with ellipsis in navigation items
  • Optimized spacer component rendering to appear only when needed

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant