Add no-seed configuration to database:reset #9112
Merged
+29
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixMalfait
commented
Dec 18, 2024
| @@ -56,7 +56,7 @@ rawDataSource | |||
| ]; // See https://supabase.github.io/wrappers/ | |||
|
|
|||
| for (const wrapper of supabaseWrappers) { | |||
| if (await checkForeignDataWrapperExists(wrapper)) { | |||
| if (await checkForeignDataWrapperExists(`${wrapper.toLowerCase()}_fdw`)) { | |||
There was a problem hiding this comment.
No related to PR title but this was a small error I noticed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a no-seed configuration option to the database:reset command to address login issues in self-hosted environments.
- Added
no-seedconfiguration in/packages/twenty-server/project.jsonthat skips workspace seeding during database reset - Modified foreign data wrapper checks in
/packages/twenty-server/scripts/setup-db.tsto properly append '_fdw' suffix - Added warning in documentation about database erasure during reset operations
- Fixed issue with multiple workspaces being created in single-workspace mode
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -37,7 +37,7 @@ Note : you can run `npx nx run twenty-server:test:integration:with-db-reset` in | |||
|
|
|||
| ### Resetting the database | |||
|
|
|||
| If you want to reset the database, you can run the following command: | |||
| If you want to reset and seed the database, you can run the following command: | |||
There was a problem hiding this comment.
logic: should also mention that seeding is optional and document the no-seed flag if that's being added
charlesBochet
approved these changes
Dec 18, 2024
|
LGTM, linter is red! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback here:
#9109 (comment)