Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-domain): allow to use custom domain #9106

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AMoreaux
Copy link
Contributor

@AMoreaux AMoreaux commented Dec 17, 2024

Features:

  • Allow to set a custom domain
  • Allow to delete a custom domain
  • Allow to update a custom domain
  • Change domain management to allow usage of a custom domain, subdomain, or a single workspace instance.
  • Implement the settings page to be able to set a custom domain

Resources:

Notion:

https://mulberry-crowley-a94.notion.site/12106d668cc9803383b3e0d8ac752605?v=12106d668cc980e193cb000c06d256d7

Figma:

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=43118-109927&t=ss0P7BqLKs4RCyXq-0

Refactor subdomain generation logic to a dedicated utility while adding comprehensive tests for subdomain handling. Introduce Cloudflare-based custom domain management functions and exceptions for better domain lifecycle management. Simplify workspace domain updates and enhance overall validation processes.
@AMoreaux AMoreaux self-assigned this Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

Warnings
⚠️ Changes were made to the environment variables, but not to the documentation - Please review your changes and check if a change needs to be documented!

Generated by 🚫 dangerJS against 1256151

Update terminology across services, entities, and exceptions from 'domain' to 'hostname' for consistency and clarity. Adjust related methods, fields, and exception codes accordingly. Ensure backward compatibility is maintained while implementing the new naming convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants