Fix: Make DropdownMenuSeparator background transparent based on theme #9037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the padding-left for the chip component when the variant is Transparent. The padding-left is now set to 2px to ensure proper alignment, while other variants continue to use the default horizontal padding.
- Increased padding-left for table cells from 6px to 8px for uniform spacing. - Set padding to 0px for Chip component in transparent mode to prevent it from affecting cell padding and ensure consistent 8px left padding across all cells.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated the DropdownMenuSeparator component to use theme-based transparent background colors, improving visual consistency in dropdown menus.
- Modified
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuSeparator.tsxto usetheme.background.transparent.lightfor dark theme - Inconsistent indentation in the component styling needs to be fixed
- Theme-based color implementation only partially addresses issue Borders / separators should be transparent #8993, as light theme still uses
border.color.light
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
4
to
7
| background-color: ${({ theme }) => | ||
| theme.name === 'dark' | ||
| ? theme.background.transparent.light | ||
| : theme.border.color.light}; |
There was a problem hiding this comment.
style: Inconsistent indentation in the template literal
|
@lucasbordeau please review it |
|
Could you please provide screenshots of an example of DropdownMenuSeparator both light and dark mode before and after ? |
|
@lucasbordeau Dark: After: Dark: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #8993 by updating the
DropdownMenuSeparatorto adjust its background color based on the current theme.