Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix :update message for permanent record deletion #8864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omarNaifer12
Copy link
Contributor

Resolves #8690

Problem:
When permanently deleting records, the message displayed is the same as for general records. This can cause confusion, so we should update the message to reflect the correct context.

Solution:
I tried to extract the value of softDeleteFilterActive. Based on its value:

If true, it means we are on the page of deleted records.
If false, it means we are on the page of general records.

Please feel free to review it and let me know if you have a better approach. This is the only solution that worked for me after trying other approaches, which didn’t work as expected.

All-Companies-Personal-MicrosoftEdge2024-12-0400-37-01-ezgif com-video-to-gif-converter

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the deletion confirmation modal messaging to provide clearer context about record deletion permanence.

  • Added conditional messaging in useDeleteSingleRecordAction.tsx based on isSoftDeleteFilterActive state
  • When deleting from deleted records view, warns user about permanent/unrecoverable deletion
  • When deleting from normal view, informs user records can be recovered from Options menu
  • Uses isSoftDeleteFilterActiveComponentState to determine deletion context

💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thank you for contributing @omarNaifer12 :)
Could you resolve your conflicts and check the tests so we can merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deleting permamently records, popup message must be more clear
3 participants