Added containers for testing #8707
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added Docker container configurations for testing authentication and webhook functionality in the e2e testing environment.
- Added
mock-samlcontainer setup inpackages/twenty-e2e-testing/Makefilefor SAML authentication testing - Added
smtp4devcontainer in Makefile for email testing on ports 8090, 2525, and 143 - Created isolated webhook testing environment in
containers/webhook.ymlwith separate Redis instance to avoid conflicts - Configured webhook.site container with Laravel Echo server for real-time event handling
- Requires configuration of public/private key pair for mock-saml container before use
2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| docker run \ | ||
| --name mock_saml \ | ||
| -p 4000:4000 \ | ||
| -e APP_URL="http://localhost:4000" \ | ||
| -e ENTITY_ID="https://saml.example.com/entityid" \ | ||
| -e PUBLIC_KEY= \ | ||
| -e PRIVATE_KEY= \ | ||
| -d boxyhq/mock-saml |
There was a problem hiding this comment.
style: No restart policy specified - container will not automatically restart if it crashes
|
Hi @BOHEUS, thanks for all the PRs. I'm missing context about this one, why do we need these containers for?
|
|
The idea behind this was to help with testing locally if someone, who wants to run these tests, doesn't have needed accounts to run these tests (and prevent from being banned thanks to high usage of free online versions) |
Related to #8469 and #6641
Webhook.site container must be in compose file as it requires 3 containers, one of them being Redis which is already used by Twenty. To prevent any problems with running 2 Redis containers simultaneously, network was created to separate both containers.