Refactored and improved seeds #8695
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds comprehensive seeding functionality and rich text field support across the application, including new demo data and field types for testing.
- Added RichTextFieldInput with BlockNote editor integration for inline rich text editing in tables
- Introduced new SeederService with support for custom objects, composite fields, and improved data seeding capabilities
- Added 10 new demo field types to Company seeds (UUID, RichText, Array, Rating, etc.) with corresponding metadata and views
- Added new seed data files for pets and survey results with 100 records each for testing
- Fixed color naming consistency from 'grey' to 'gray' across multiple theme and UI files
51 file(s) reviewed, 36 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/object-record/record-field/components/FieldInput.tsx
Show resolved
Hide resolved
| const persistField = usePersistField(); | ||
|
|
||
| const persistRichTextField = (nextValue: PartialBlock[]) => { | ||
| if (!nextValue) persistField(null); |
There was a problem hiding this comment.
logic: Missing return after setting null - could cause undefined behavior by continuing execution
| const draftValueParsed: PartialBlock[] = isNonEmptyString(draftValue) | ||
| ? JSON.parse(draftValue) | ||
| : draftValue; |
There was a problem hiding this comment.
logic: JSON.parse could throw if draftValue is malformed JSON - needs try/catch
...ges/twenty-front/src/modules/object-record/record-field/meta-types/hooks/useRichTextField.ts
Show resolved
Hide resolved
| fieldName, | ||
| ); | ||
|
|
||
| const fieldValueParsed = parseJson<PartialBlock[]>(fieldValue); |
There was a problem hiding this comment.
logic: parseJson could return undefined/null - need to handle this case explicitly to avoid runtime errors when using fieldValueParsed
packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.ts
Show resolved
Hide resolved
| @WorkspaceIsNullable() | ||
| demoRichText: string; |
There was a problem hiding this comment.
logic: demoRichText should be typed as FieldRichTextValue or string[] instead of string to match the RichText field type
packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-field/types/FieldMetadata.ts
Outdated
Show resolved
Hide resolved
| @@ -8,7 +8,7 @@ export const DEMO_SEED_WORKSPACE_MEMBER_IDS = { | |||
| TIM: '20202020-1553-45c6-a028-5a9064cce07e', | |||
| }; | |||
|
|
|||
| export const workspaceMemberPrefillData = async ( | |||
| export const seedWorkspaceMemberWithDemoData = async ( | |||
There was a problem hiding this comment.
we move it out from prefill data, aren't we breaking workspace creation?
There was a problem hiding this comment.
I need to check
...-server/src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts
Outdated
Show resolved
Hide resolved
|
Small comment from @Bonapara: the default workspace of Tim Apple should be Apple and not ACME |
|
Maybe we could use a fake logo to make it more fun:
|
Fixes #6793